parity: add LCOW document permutation tests#2631
Open
shreyanshjain7174 wants to merge 1 commit intomicrosoft:mainfrom
Open
parity: add LCOW document permutation tests#2631shreyanshjain7174 wants to merge 1 commit intomicrosoft:mainfrom
shreyanshjain7174 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
6a7f064 to
917d728
Compare
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
917d728 to
c24edac
Compare
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
c24edac to
82096da
Compare
Restructure parity test framework and add permutation-based tests for LCOW HCS document creation comparing legacy and v2 builder outputs. Signed-off-by: Shreyansh Sancheti <shreyanshjain7174@gmail.com> Signed-off-by: Shreyansh Sancheti <shsancheti@microsoft.com>
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
82096da to
f71836c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the LCOW parity test infrastructure from #2629 with permutation tests that exercise annotation and option combinations triggering different document construction branches in the legacy and v2 pipelines.
Changes
Permutation tests (
TestLCOWDocumentParityPermutations)19 test cases covering:
Gap tests
3 tests documenting known v2 builder differences using inverted assertions (they expect a diff and only fail if the documents unexpectedly match):
CpuGroup = nilCpuGroup = &{Id:""}StorageQoS = nilStorageQoS = &{}VirtualPMem = nilThese are tracked for fixes in the v2 builder (see #2630).
Kernel cmdline whitespace handling
Added
normalizeKernelCmdLineandisOnlyKernelCmdLineWhitespaceDiffhelpers. The legacy builder produces a leading space in kernel command lines for initrd+KernelDirect boot that the v2 builder correctly omits. Since HCS trims whitespace, this difference is harmless and we warn instead of failing.Depends on